[PATCH] D111164: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations

[Nuri Amari via Phabricator via llvm-commits]

nuriamari added a comment.

In D111164#3052797 <https://reviews.llvm.org/D111164#3052797>, @alexander-shaposhnikov wrote:

> adding / removing load commands (e.g. rpath) can trigger such changes (but beware the alignment + the order of load commands matters) so the test needs to be specifically designed for these purposes
>
> (I would use llvm-objdump or llvm-readobj to verify that the offset of __TEXT has changed etc)
>
> P.S. btw - you probably want to update TextSegmentCommandIndex inside updateLoadCommandIndexes(..) and such a test would catch it, alternatively, it can be calculated where it's actually used (and the field can be dropped)

Hi Alexander,

Thanks for your feedback, sorry I've been a little inactive the last few days. I have moved the CodeSignatureInfo struct and I will add a new test like you are suggesting. I am little busy with other work at the moment, but I will try to get to it later this week.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111164/new/

https://reviews.llvm.org/D111164