[PATCH] D111660: [FuncSpec] Make sure function is actually the callee before trying to specialize.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 11:27:21 PDT 2021


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:665
       auto &CS = *cast<CallBase>(U);
+      if (CS.getCalledFunction() != F) {
+        continue;
----------------
Hmmm, interesting. Can this lead to a miscompute, or other problems?  I think we need to add a test to trigger that (which this patch fixes)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111660/new/

https://reviews.llvm.org/D111660



More information about the llvm-commits mailing list