[PATCH] D111523: [AMDGPU] Fix 24 bit mul intrinsic generation for > 32 bit result.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

You now need to add tests where we prove it fits 32 bits and use 24 bit mul.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp:523
+  if (Size > 32 &&
+      numBitsUnsigned(LHS, Size) + numBitsUnsigned(RHS, Size) > 32) {
+    return false;
----------------
Should we use a signed check for signed mul?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111523/new/

https://reviews.llvm.org/D111523