[PATCH] D111151: [CodeGen][Outliner] Fix CFICount calculations

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexander-shaposhnikov added a comment.

@paquette - many thanks for the review, regarding the test case it looks like there are some complications:

1. whenever we parse .mir MIParser populates FrameInstructions (see MIParser::parseCFIOperand) regardless of the fact if they belong to prologue or not. This creates a discrepancy with the real behavior of CodeGen

(it's particularly easy to observe for x86_64, since for x86_64  LLVM emits the correct cfi_directives in the epilogue), so in general getFrameInstructions().size() doesn't return the total number of cfi directives (unless the input was .mir),
but changing the behavior of MIParser appears to require some efforts.

2. The higher-level input (e.g. IR) doesn't give enough control to  easily trigger this issue, but maybe I'm missing something ?

It caught my eye (together with the dead code on the lines 9130, 9133, 9134) while  I was working on some other stuff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111151/new/

https://reviews.llvm.org/D111151