[PATCH] D111524: [GlobalISel] Add support for constant vector folding of binops in CSEMIRBuilder.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-getelementptr.ll:195
   ; CHECK-NEXT:   [[C2:%[0-9]+]]:_(s64) = G_CONSTANT i64 4
   ; CHECK-NEXT:   [[BUILD_VECTOR3:%[0-9]+]]:_(<2 x s64>) = G_BUILD_VECTOR [[C2]](s64), [[C2]](s64)
+  ; CHECK-NEXT:   [[C3:%[0-9]+]]:_(s64) = G_CONSTANT i64 8
----------------
foad wrote:
> BUILD_VECTOR2 and BUILD_VECTOR3 are dead now. I guess we don't do anything to clean up dead code at the end of IRTranslator?
Correct, usually the prelegalizer combiner will handle this immediately after.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111524/new/

https://reviews.llvm.org/D111524