[PATCH] D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution

Tue Oct 12 09:50:09 PDT 2021

kiranchandramohan added a comment.

In D110502#3058967 <https://reviews.llvm.org/D110502#3058967>, @NimishMishra wrote:

> Thanks @kiranchandramohan and @clementval for comments on the patch. I am working on another hint clause related patch and am taking forward a little TODO to it: improving hint clause comparison.

OK

> @kiranchandramohan You mentioned cherry picking this to fir-dev. Do you want just this patch or sections patch as well in the cherry picking?

Just this patch.

> Also whenever your bandwidth allows, please have a quick look at https://reviews.llvm.org/D110714. There's a little question I have posted regarded design choice of a function. Once resolved, I can spend time on that revision too and take it to closure.

I will have a look tomorrow.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110502/new/

https://reviews.llvm.org/D110502