[PATCH] D111397: RFC: A new way of skipping machine verification after problematic passes

Tue Oct 12 09:40:35 PDT 2021

MatzeB added a comment.

In D111397#3050710 <https://reviews.llvm.org/D111397#3050710>, @foad wrote:

> This is an RFC to see if people like the idea.
>
> Known issues:
>
> 1. I'm not sure if the new "Verifies" property needs to be serialised in .mir files.

Yes I think so.

> 2. When you look at the TargetMachine class for a particular target, it's not very easy to see where the "Verifies" flag gets turned off and on -- you have to look into the individual passes. It would be easy to have it turned off at one point in the middle of the pass pipeline, and forget to turn it on again later.

Well, I don't think we have a better solution. Regardless it's better than what we currently have.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111397/new/

https://reviews.llvm.org/D111397