[PATCH] D109852: [IR] Return AAMDNodes from Instruction::getMetadata() (NFC)

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere added inline comments.


================
Comment at: llvm/include/llvm/IR/Metadata.h:713
+  /// determine the best AAMDNodes that apply to both.
+  AAMDNodes merge(const AAMDNodes &Other) const;
 };
----------------
Maybe interesting to add a LLVM_NODISCARD ? This should avoid missuses like:
  Nodes.merge(OtherNodes);



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109852/new/

https://reviews.llvm.org/D109852