[PATCH] D111602: [SCEV][NFC] Tackle quadratic CT consumption in forgetValue

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 09:03:59 PDT 2021


mkazantsev added a comment.

I think we can do more of this kind, e.g. in forgetLoops. Will look into it more.



================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:7576
         eraseValueFromMap(It->first);
         forgetMemoizedResults(It->second);
         if (PHINode *PN = dyn_cast<PHINode>(I))
----------------
nikic wrote:
> We should be collecting these into a vector as well.
Good point!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111602/new/

https://reviews.llvm.org/D111602



More information about the llvm-commits mailing list