[llvm] f7ee21a - [TwoAddressInstruction] Remove ad hoc machine verification

[Jay Foad via llvm-commits]

Author: Jay Foad
Date: 2021-10-12T16:09:18+01:00
New Revision: f7ee21aa326fcd07448d5162daf66f3675ffa863

URL: https://github.com/llvm/llvm-project/commit/f7ee21aa326fcd07448d5162daf66f3675ffa863
DIFF: https://github.com/llvm/llvm-project/commit/f7ee21aa326fcd07448d5162daf66f3675ffa863.diff

LOG: [TwoAddressInstruction] Remove ad hoc machine verification

With the -early-live-intervals command line flag,
TwoAddressInstructionPass::runOnMachineFunction would call
MachineFunction::verify before returning to check the live intervals.
But there was not much benefit to doing this since -verify-machineinstrs
and LLVM_ENABLE_EXPENSIVE_CHECKS provide a more general way of
scheduling machine verification after every pass.

Also it caused problems on targets like Lanai which are marked as "not
machine verifier clean", since verification would fail for known
target-specific problems which are nothing to do with LiveIntervals.

Differential Revision: https://reviews.llvm.org/D111618

Added: 
    

Modified: 
    llvm/lib/CodeGen/TwoAddressInstructionPass.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/TwoAddressInstructionPass.cpp b/llvm/lib/CodeGen/TwoAddressInstructionPass.cpp
index 23e168532594..461d25e39568 100644
--- a/llvm/lib/CodeGen/TwoAddressInstructionPass.cpp
+++ b/llvm/lib/CodeGen/TwoAddressInstructionPass.cpp
@@ -1742,9 +1742,6 @@ bool TwoAddressInstructionPass::runOnMachineFunction(MachineFunction &Func) {
     }
   }
 
-  if (LIS)
-    MF->verify(this, "After two-address instruction pass");
-
   return MadeChange;
 }