[PATCH] D108115: [DAG][sve] Lowering for VLS masked truncating stores

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 07:40:10 PDT 2021


DavidTruby added a comment.

In D108115#3048051 <https://reviews.llvm.org/D108115#3048051>, @dmgreen wrote:

> Sorry for the delay. I missed this as something I should be looking at.

No problem, thanks for the review.

> I've had a look around, and I can't see anything obvious that goes wrong with this. canCombineTruncStore is a bit overloaded between stores and masked stores - it relies on the support being symetrical.

I see what you mean about this one but I don't see an obvious way around it other than replicating all the `getTruncStoreAction` etc logic for masked stores separately. This might be the right thing to do in the end though? I'm open to other suggestions as doing that might be a bit of a pain!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108115/new/

https://reviews.llvm.org/D108115



More information about the llvm-commits mailing list