[PATCH] D110165: [DebugInfo][NFC] Move LiveDebugValues class declaration to a header, add unit test boilerplate

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:40
+
+// XXX XXX XXX docs
+class LocIdx {
----------------
aprantl wrote:
> ?
Erk, forgot to copy across documentation for this class, will fold that in.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h:121
+public:
+  // XXX -- temporarily enabled while the live-in / live-out tables are moved
+  // to something more type-y
----------------
aprantl wrote:
> ?
When this was originally looked at by Vedant last year, he suggested that there shouldn't be an "empty" or "illegal" value number. Avoiding having to think about an extra edge case makes reasoning a lot easier, so I removed the empty value number. But then I started using the IndexedMap container, which needs a "null" value to work, so put it back. And apparently this comment too.

I'll replace this with an explanation of where the "empty" value is used, and why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110165/new/

https://reviews.llvm.org/D110165