[PATCH] D111611: [NFC] [LoopPeel] Change the way DT is updated for loop exits

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopPeel.cpp:753
     cloneLoopBlocks(L, Iter, InsertTop, InsertBot, ExitEdges, NewBlocks,
                     LoopBlocks, VMap, LVMap, DT, LI,
                     LoopLocalNoAliasDeclScopes);
----------------
fhahn wrote:
> Passing `DT` means that `cloneLoopBlocks` previously could rely on `DT` being up to date here. That's not true any more, as it is only updated later. Is that a problem? We also need to check all other uses of plain `DT` in until the updates are applied.
We can completely remove DT from the signatures here and pass it updates for filling as well. Also may be faster.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111611/new/

https://reviews.llvm.org/D111611