[PATCH] D111317: [DebugInfo][InstrRef] Track instructions that write-to-stack after having a spill fused into them

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:1321
 
+  // Reject any memory operand that's aliased -- we can't guarantee its value.
+  auto MMOI = MI.memoperands_begin();
----------------
StephenTozer wrote:
> Just out of curiosity, does this represent a bug prior to this patch, or is this just needed for the new functionality?
I don't thiiiiink so: I've added this as an act of conservativeness, in case the target hooks recognise any stack write as being a stack spill. I suspect this doesn't happen for x86; perhaps it happens for other architectures though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111317/new/

https://reviews.llvm.org/D111317