[PATCH] D111629: [fir][NFC] Add disclaimer to affine promotion/demotion passes

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 03:59:45 PDT 2021


clementval created this revision.
clementval added reviewers: jeanPerier, svedanayagam, sscalpone, kiranchandramohan, jdoerfert, schweitz, pmccormick, mehdi_amini, rovka, AlexisPerry.
Herald added a subscriber: Groverkss.
Herald added a project: Flang.
clementval requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

AffinePromotion and AffineDemotion passes where upstreamed
in their current status from fir-dev. In order to make sure everybody
is on the same page, this patch add some comments to state that.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111629

Files:
  flang/lib/Optimizer/Transforms/AffineDemotion.cpp
  flang/lib/Optimizer/Transforms/AffinePromotion.cpp


Index: flang/lib/Optimizer/Transforms/AffinePromotion.cpp
===================================================================
--- flang/lib/Optimizer/Transforms/AffinePromotion.cpp
+++ flang/lib/Optimizer/Transforms/AffinePromotion.cpp
@@ -5,6 +5,15 @@
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
+//
+// This transformation is a prototype that promote FIR loops operations
+// to affine dialect operations.
+// It is not part of the production pipeline and would need more work in order
+// to be used in production.
+// More information can be found in this presentation:
+// https://slides.com/rajanwalia/deck
+//
+//===----------------------------------------------------------------------===//
 
 #include "PassDetail.h"
 #include "flang/Optimizer/Dialect/FIRDialect.h"
@@ -31,8 +40,8 @@
 struct AffineIfAnalysis;
 
 /// Stores analysis objects for all loops and if operations inside a function
-///  these analysis are used twice, first for marking operations for rewrite and
-///  second when doing rewrite.
+/// these analysis are used twice, first for marking operations for rewrite and
+/// second when doing rewrite.
 struct AffineFunctionAnalysis {
   explicit AffineFunctionAnalysis(mlir::FuncOp funcOp) {
     for (fir::DoLoopOp op : funcOp.getOps<fir::DoLoopOp>())
Index: flang/lib/Optimizer/Transforms/AffineDemotion.cpp
===================================================================
--- flang/lib/Optimizer/Transforms/AffineDemotion.cpp
+++ flang/lib/Optimizer/Transforms/AffineDemotion.cpp
@@ -5,6 +5,16 @@
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
+//
+// This transformation is a prototype that demote affine dialects operations
+// after optimizations to FIR loops operations.
+// It is used after the AffinePromotion pass.
+// It is not part of the production pipeline and would need more work in order
+// to be used in production.
+// More information can be found in this presentation:
+// https://slides.com/rajanwalia/deck
+//
+//===----------------------------------------------------------------------===//
 
 #include "PassDetail.h"
 #include "flang/Optimizer/Dialect/FIRDialect.h"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111629.378960.patch
Type: text/x-patch
Size: 2323 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211012/7ec0a7a0/attachment.bin>


More information about the llvm-commits mailing list