[PATCH] D110502: [Flang][openmp] Add semantic checks for OpenMP critical construct name resolution

Tue Oct 12 03:00:55 PDT 2021

kiranchandramohan added a comment.

In D110502#3057696 <https://reviews.llvm.org/D110502#3057696>, @NimishMishra wrote:

> In D110502#3057634 <https://reviews.llvm.org/D110502#3057634>, @kiranchandramohan wrote:
>
>> @NimishMishra  Can you prioritise this patch for completion today?
>
> Okay. I have added one hint clause semantic check as well. Hope that is fine too. It also has to done with name resolution problem only: namely, a hint clause can't exist on a critical directive that is unnamed.
>
> Everything is ready. As soon as advise on this, I push the revised diff here.

Yes, please add that check also to this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110502/new/

https://reviews.llvm.org/D110502