[PATCH] D111125: [NFC][LoopVectorize] Remove setBestPlan in favour of getBestPlanFor

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 12 00:31:34 PDT 2021


david-arm added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8208
   // 1. Create a new empty loop. Unlink the old loop and connect the new one.
-  assert(BestVF.hasValue() && "Vectorization Factor is missing");
-  assert(VPlans.size() == 1 && "Not a single VPlan to execute.");
-
-  VPTransformState State{
-      *BestVF, BestUF, LI, DT, ILV.Builder, &ILV, VPlans.front().get()};
+  VPTransformState State{BestVF, BestUF,         LI, DT, ILV.Builder,
+                         &ILV,   BestVPlan.get()};
----------------
sdesmalen wrote:
> nit: odd spaces?
Yeah, clang-format does that, which surprised me too. I can try to remove the spaces, but I have a feeling I will then be told to fix up formatting. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111125/new/

https://reviews.llvm.org/D111125



More information about the llvm-commits mailing list