[PATCH] D111586: [Inline] Make sure the InlineAdvisor is correctly cleared.

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:1055
+  Inv.abandon<InlineAdvisorAnalysis>();
+  MAM.invalidate(M, Inv);
   // The ModulePassManager has already taken care of invalidating analyses.
----------------
aeubanks wrote:
> can we
> ```
> auto PA = PreservedAnalyses::all();
> PA.abandon<>();
> return PA;
> ```
> instead? and add a comment
done. btw, the newpm tests (e.g. Other/new-pm-defaults, etc) need updating. I'll do it once everything else looks OK 

(...which is really just me procrastinating)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111586/new/

https://reviews.llvm.org/D111586