[PATCH] D107688: [JITLink][RISCV] Support GOT/PLT relocations
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 11 19:26:05 PDT 2021
jrtc27 added inline comments.
Herald added a subscriber: achieveartificialintelligence.
================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp:83
+ if (!GOTSection)
+ GOTSection = &G.createSection("$__GOT", sys::Memory::MF_READ);
+ return *GOTSection;
----------------
These look like Mach-O-isms, where sections are generally called `__FOO`. The ELF names for sections is normally `.foo`; e.g. the GOT is normally in a `.got` section. This does not make sense as an ELF section name. Assuming "stubs" here means PLT, it should be in a `.plt` section.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107688/new/
https://reviews.llvm.org/D107688
More information about the llvm-commits
mailing list