[PATCH] D111515: [InstCombine] Remove attributes after hoisting free above null check

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai requested review of this revision.
smeenai added a comment.

Thanks for the review!

I decided to take the more precise approach, because it seemed cleaner and was a good excuse for me to learn more of the attribute APIs :) I agree about the preciseness being unnecessary, but it shouldn't hurt either.

I'm requesting review again because I've never worked with attributes before, so I wanted to double check that (a) this is what you had in mind, and (b) there's not a simpler way to do the attribute replacement (it's a bit annoying that `CallBase` supports `addDereferenceableParamAttr` directly but adding `dereferenceable_or_null` requires going through `AttributeList`, but it also seemed overkill to add that method for this single use case). Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111515/new/

https://reviews.llvm.org/D111515