[PATCH] D111414: [Demangle] Add minimal support for D programming language

[Luís Ferreira via Phabricator via llvm-commits]

ljmf00 added inline comments.


================
Comment at: llvm/unittests/Demangle/DLangDemangleTest.cpp:25
+
+  ExpectedVal ExpectedArray[] = {
+      {"_Dmain", "D main"}
----------------
ljmf00 wrote:
> jhenderson wrote:
> > gtest has specific support for parameterised tests (see the `TEST_P` macro), so it probably makes more sense to leverage that rather than hand-roll your own looping logic. This is particularly important, because it impacts how test failures are reported.
> Done
I'm not too familiar with gtest, so extra guidance is appreciated. I'm not sure if an empty fixture is the best fit here, tho


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111414/new/

https://reviews.llvm.org/D111414