[PATCH] D107872: [SimplifyLibCalls] propagate tail/musttail/notail flags on CallInsts
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 11 15:28:37 PDT 2021
nickdesaulniers added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:630
return Dst;
}
----------------
jdoerfert wrote:
> Mostly this makes sense but doesn't this violate tail properties now? The old call result was return but it is not anymore.
perhaps we should be avoiding libcall transforms that don't return the new `CallInst` if the `CallInst` to be replaced is marked `musttail`? Let me add `musttail` tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107872/new/
https://reviews.llvm.org/D107872
More information about the llvm-commits
mailing list