[PATCH] D109958: [LoopFlatten] Enable it by default

Alan Phipps via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 11 14:23:59 PDT 2021


alanphipps added a comment.

In D109958#3056240 <https://reviews.llvm.org/D109958#3056240>, @SjoerdMeijer wrote:

> I assume you have a downstream change to enable it by default, just like us. So if we are going to enable this by default under the NPM, I am not sure if anything will change for you

Yes, fair enough -- rereading the discussion, I was concerned that the MemorySSA issue for the LPM wasn't well understood and perhaps something was being overlooked in the implementation, but it sounds like the concern is more pertinent to performance impact/fluctuation on the LPM and not the implementation itself, which is complete.  I think we are good enabling it downstream.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109958/new/

https://reviews.llvm.org/D109958



More information about the llvm-commits mailing list