[llvm] fbddf22 - [SCCP] Properly report changes when changing a pointer argument

[Arthur Eubanks via llvm-commits]

Author: Arthur Eubanks
Date: 2021-10-11T13:12:08-07:00
New Revision: fbddf22ef72d3c2e9b14e1501841b03380eef12b

URL: https://github.com/llvm/llvm-project/commit/fbddf22ef72d3c2e9b14e1501841b03380eef12b
DIFF: https://github.com/llvm/llvm-project/commit/fbddf22ef72d3c2e9b14e1501841b03380eef12b.diff

LOG: [SCCP] Properly report changes when changing a pointer argument

Fixes one of the issues in PR51946.

Reviewed By: asbirlea

Differential Revision: https://reviews.llvm.org/D111277

Added: 
    llvm/test/Transforms/SCCP/report-changed.ll

Modified: 
    llvm/lib/Transforms/Scalar/SCCP.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/SCCP.cpp b/llvm/lib/Transforms/Scalar/SCCP.cpp
index a57159c6708b0..28e00c8733610 100644
--- a/llvm/lib/Transforms/Scalar/SCCP.cpp
+++ b/llvm/lib/Transforms/Scalar/SCCP.cpp
@@ -500,6 +500,7 @@ bool llvm::runIPSCCP(
           CB->removeFnAttrs(AttributesToRemove);
         }
       }
+      MadeChanges |= ReplacedPointerArg;
     }
 
     SmallPtrSet<Value *, 32> InsertedValues;

diff  --git a/llvm/test/Transforms/SCCP/report-changed.ll b/llvm/test/Transforms/SCCP/report-changed.ll
new file mode 100644
index 0000000000000..473c16b78f381
--- /dev/null
+++ b/llvm/test/Transforms/SCCP/report-changed.ll
@@ -0,0 +1,34 @@
+; RUN: opt -passes='require<no-op-module>,ipsccp' -disable-output < %s 2>&1 -debug-pass-manager | FileCheck %s
+
+; CHECK: Invalidating {{.*}} NoOpModuleAnalysis
+
+define i16 @main() {
+entry:
+  %call10 = call i16 @test_local_fp3(i16 undef)
+  ret i16 0
+}
+
+declare i16 (i16, i16)* @add_fp2()
+
+define internal i16 (i16, i16)* ()* @add_fp3() {
+entry:
+  ret i16 (i16, i16)* ()* @add_fp2
+}
+
+define internal i16 @test_local_fp3(i16 %tnr) {
+entry:
+  %tnr.addr = alloca i16, align 1
+  %call10 = call i16 @apply_fp3_local(i16 (i16, i16)* ()* ()* @add_fp3, i16 181, i16 16384)
+  %0 = load i16, i16* %tnr.addr, align 1
+  ret i16 %0
+}
+
+define internal i16 @apply_fp3_local(i16 (i16, i16)* ()* ()* %fp, i16 %p1, i16 %p2) {
+entry:
+  %fp.addr = alloca i16 (i16, i16)* ()* ()*, align 1
+  store i16 (i16, i16)* ()* ()* %fp, i16 (i16, i16)* ()* ()** %fp.addr, align 1
+  %0 = load i16 (i16, i16)* ()* ()*, i16 (i16, i16)* ()* ()** %fp.addr, align 1
+  %call = call i16 (i16, i16)* ()* %0()
+  %call2 = call i16 undef(i16 undef, i16 undef)
+  ret i16 %call2
+}