[PATCH] D111437: [SystemZ/z/OS] Implement GOFF writer for empty files

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 11 13:04:58 PDT 2021


kpn added inline comments.


================
Comment at: llvm/lib/MC/GOFFObjectWriter.cpp:274
+  OS.write_zeros(3);                           // Reserved
+  OS.write_be<uint32_t>(OS.logical_records()); // Record Count
+  OS.write_be<uint32_t>(ESDID);                // ESDID (of entry point)
----------------
I have found it useful to use the Unix 'dd' command to slide up GOFF files when they cause the Binder to abend. This becomes much harder when this record count field is used. I'm not sure what the upside of this field is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111437/new/

https://reviews.llvm.org/D111437



More information about the llvm-commits mailing list