[PATCH] D108114: [LoopPeel] Peel if it turns invariant loads dereferenceable.

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D108114#3055669 <https://reviews.llvm.org/D108114#3055669>, @fhahn wrote:

> @reames do the latest update / the recent responses address your concerns?

Yep, you addressed the major concerns.  I think you could stand to wordsmith the function comment and submit message a bit to be clearer about the new heuristic, but the code addresses my concerns.

Note that I have not done a detailed code review as the patch was already LGTMed by others.  I skimmed and didn't spot anything huge, but it was only a skim.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108114/new/

https://reviews.llvm.org/D108114