[PATCH] D109958: [LoopFlatten] Enable it by default

Alan Phipps via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 11 11:33:28 PDT 2021


alanphipps added a comment.

> There are already a good number of divergences between the two pass managers, I don't see the harm in keeping the LPM pipeline the same. Do you specifically care about this pass?

Yes, we asked about loop flattening a year ago along with a jump threading improvement in the context of improving the Coremark, and @SjoerdMeijer indicated that there was a pending code review.  I can appreciate that there are already divergences between the two pass managers.  If there is a possibility of regression on the LPM in this case, then I can understand not enabling it by default.  We can explore enabling it downstream, but any other information about impact to the LPM would be helpful and appreciated.  Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109958/new/

https://reviews.llvm.org/D109958



More information about the llvm-commits mailing list