[PATCH] D110776: A new hidden option test-changed=exe that calls exe after each time IR changes

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

super nit, the title doesn't need to specify that the option is "hidden", that is definitely not important enough to be in the title

I think this could be useful, although I believe opt-bisect would also work for your use case



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:138
+template <unsigned M, unsigned N = 0>
+std::string prepareTempFiles(int (&FD)[M + N], const StringRef (&SR)[M],
+                             std::string (&FileName)[M + N]) {
----------------
This is way too simple of a function to use templates. They're very hard to read and are bad for compile times.
I'd say to avoid C arrays and use SmallVector/ArrayRef whenever possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110776/new/

https://reviews.llvm.org/D110776