[PATCH] D108741: [IR][GlobalDCE] Add ability to mark vtable methods as eligible for VFE and avoid eliminating non-eligible vfunc in VFE in GlobalDCE

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: llvm/include/llvm/AsmParser/LLParser.h:65
     std::unique_ptr<Constant *[]> ConstantStructElts;
+    bool VFEEligible = false;
 
----------------
fhahn wrote:
> Why is this needed? Can this be handled in a similar fashion to how other constants are handled?
I don't think it's really needed, I took this approach from <https://reviews.llvm.org/D108478>. I've just replaced it with the more "local" approach of handling everything in the `lltok::kw_vfe_eligible` case in `LLParser::parseValID`. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108741/new/

https://reviews.llvm.org/D108741