[PATCH] D111508: [RISCV] Optimize immediate materialisation with BSETI/BCLRI

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 11 09:40:30 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVMatInt.cpp:195
+    generateInstSeqImpl(Lo, ActiveFeatures, TmpSeq);
+    // Check if it is profitable to use BCLI/BSETI.
+    if (Lo > 0 && TmpSeq.size() + countPopulation(Hi) < Res.size()) {
----------------
BCLI -> BCLRI


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVMatInt.cpp:202
+    }
+    // Search for each bit and build cprresponding BCLRI/BSETI.
+    if (Opc > 0) {
----------------
cprresponding -> corresponding


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111508/new/

https://reviews.llvm.org/D111508



More information about the llvm-commits mailing list