[PATCH] D109676: [HardwareLoops] put +1 for loop count before zero extension

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D109676#3039130 <https://reviews.llvm.org/D109676#3039130>, @shchenz wrote:

> Hi @reames , do you have further comments for this patch? Thanks.

Sorry, your last response didn't parse for me.  I know the SCEV side of this, but the client pieces are going over my head.

My general suggestion is to rebase over D110587 <https://reviews.llvm.org/D110587> (which I'm about to land), and cleanup any downstream handling of zero trip counts separately.

We've about hit the limit of my ability to provide useful review on this, JFYI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109676/new/

https://reviews.llvm.org/D109676