[PATCH] D111550: [TwoAddressInstruction] Don't run machine verification on unclean targets
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 11 09:35:37 PDT 2021
MatzeB added inline comments.
================
Comment at: llvm/lib/CodeGen/TwoAddressInstructionPass.cpp:1659-1665
+ // TODO: Remove this ad hoc verification in favor of the usual
+ // -verify-machineinstrs mechanism.
+ if (LIS) {
+ const LLVMTargetMachine &TM = MF->getTarget();
+ if (TM.isMachineVerifierClean())
+ MF->verify(this, "After two-address instruction pass");
+ }
----------------
Could we just remove this code? Doesn't seem like we miss much since this is the last step of the pass before we would have a verifier pass scheduled anyway...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111550/new/
https://reviews.llvm.org/D111550
More information about the llvm-commits
mailing list