[PATCH] D111165: [AArch64][SVE] Add fixed type lowering for EXTRACT_SUBVECTOR

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 11 09:31:55 PDT 2021


sdesmalen accepted this revision.
sdesmalen added a comment.

Nice improvement!



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10702
+    SDValue Splice = DAG.getNode(ISD::VECTOR_SPLICE, DL, ContainerVT, NewInVec,
+                                 NewInVec, DAG.getConstant(Idx, DL, MVT::i64));
+    return convertFromScalableVector(DAG, Op.getValueType(), Splice);
----------------
I'm not sure if this really matters because it would probably reuse NewInVec anyway, but strictly this could be UNDEF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111165/new/

https://reviews.llvm.org/D111165



More information about the llvm-commits mailing list