[PATCH] D110847: [CSSPGO] Unblock optimizations with pseudo probe instrumentation part 3.

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 11 09:25:26 PDT 2021


hoy added a comment.

In D110847#3035672 <https://reviews.llvm.org/D110847#3035672>, @wenlei wrote:

> Thanks for the changes to reduce probe overhead. As we chatted off patch, some information and verification of this change's impact on profile quality would be helpful.

The original patch contained several general changes, e.g, flipping the default values of those skipping APIs, which were observed to affect profile quality. After narrowing down the offending changes that are in SimplifyCFG, reverting them brought back the profile quality while still reduced the probe overhead in a decent amount.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110847/new/

https://reviews.llvm.org/D110847



More information about the llvm-commits mailing list