[llvm] 0091e91 - [NFC][ScalarEvolution] Fix typo in getRangeForAffineAR and getRangeViaFactoring

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 11 08:50:33 PDT 2021


Thanks!  That's an incredibly misleading typo... not sure how we'd 
missed that for so long.  :)

Philip

On 10/7/21 10:59 PM, Shivam Gupta via llvm-commits wrote:
> Author: Jimmy Zhongduo Lin
> Date: 2021-10-08T11:29:49+05:30
> New Revision: 0091e913ebfac1ec4a5185cc16e3eb7549149f91
>
> URL: https://github.com/llvm/llvm-project/commit/0091e913ebfac1ec4a5185cc16e3eb7549149f91
> DIFF: https://github.com/llvm/llvm-project/commit/0091e913ebfac1ec4a5185cc16e3eb7549149f91.diff
>
> LOG: [NFC][ScalarEvolution] Fix typo in getRangeForAffineAR and getRangeViaFactoring
>
> Added:
>      
>
> Modified:
>      llvm/include/llvm/Analysis/ScalarEvolution.h
>
> Removed:
>      
>
>
> ################################################################################
> diff  --git a/llvm/include/llvm/Analysis/ScalarEvolution.h b/llvm/include/llvm/Analysis/ScalarEvolution.h
> index 9c47bc098d9b3..e10d52e3a975f 100644
> --- a/llvm/include/llvm/Analysis/ScalarEvolution.h
> +++ b/llvm/include/llvm/Analysis/ScalarEvolution.h
> @@ -1524,22 +1524,22 @@ class ScalarEvolution {
>     /// copied if its needed for longer.
>     const ConstantRange &getRangeRef(const SCEV *S, RangeSignHint Hint);
>   
> -  /// Determines the range for the affine SCEVAddRecExpr {\p Start,+,\p Stop}.
> +  /// Determines the range for the affine SCEVAddRecExpr {\p Start,+,\p Step}.
>     /// Helper for \c getRange.
> -  ConstantRange getRangeForAffineAR(const SCEV *Start, const SCEV *Stop,
> +  ConstantRange getRangeForAffineAR(const SCEV *Start, const SCEV *Step,
>                                       const SCEV *MaxBECount, unsigned BitWidth);
>   
>     /// Determines the range for the affine non-self-wrapping SCEVAddRecExpr {\p
> -  /// Start,+,\p Stop}<nw>.
> +  /// Start,+,\p Step}<nw>.
>     ConstantRange getRangeForAffineNoSelfWrappingAR(const SCEVAddRecExpr *AddRec,
>                                                     const SCEV *MaxBECount,
>                                                     unsigned BitWidth,
>                                                     RangeSignHint SignHint);
>   
>     /// Try to compute a range for the affine SCEVAddRecExpr {\p Start,+,\p
> -  /// Stop} by "factoring out" a ternary expression from the add recurrence.
> +  /// Step} by "factoring out" a ternary expression from the add recurrence.
>     /// Helper called by \c getRange.
> -  ConstantRange getRangeViaFactoring(const SCEV *Start, const SCEV *Stop,
> +  ConstantRange getRangeViaFactoring(const SCEV *Start, const SCEV *Step,
>                                        const SCEV *MaxBECount, unsigned BitWidth);
>   
>     /// If the unknown expression U corresponds to a simple recurrence, return
>
>
>          
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list