[PATCH] D111541: [Object] Deduplicate the three createError functions

[Raphael Isemann via Phabricator via llvm-commits]

teemperor added inline comments.


================
Comment at: llvm/include/llvm/Object/Error.h:85
 
+static inline Error createError(const Twine &Err) {
+  return make_error<StringError>(Err, object_error::parse_failed);
----------------
jhenderson wrote:
> I'm not sure you want the `static` keyword here? The `inline` keyword is enough to prevent ODR violations.
Thanks! (this is actually just `ELF.h` version copied here, but the static can indeed go).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111541/new/

https://reviews.llvm.org/D111541