[PATCH] D110320: [XCOFF] Improve error message context.

Raphael Isemann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 11 04:31:00 PDT 2021


teemperor added a comment.

The `createError` function introduces here breaks the LLVM_ENABLE_MODULES build:

  /Users/teemperor/5llvm/llvm-project/llvm/lib/Object/XCOFFObjectFile.cpp:46:14: error: definition with same mangled name '_ZN4llvm6objectL11createErrorERKNS_5TwineE' as another definition
  static Error createError(const Twine &Err) {
               ^
  /Users/teemperor/5llvm/llvm-project/llvm/include/llvm/Object/ELF.h:84:21: note: previous definition is here
  static inline Error createError(const Twine &Err) {
                      ^
  1 error generated.

Could we maybe move both definitions into some utility header (both functions seem to do the same thing)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110320/new/

https://reviews.llvm.org/D110320



More information about the llvm-commits mailing list