[PATCH] D110235: [LoopVectorize] Support reductions that store intermediary result

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm added reviewers: Ayal, reames, david-arm, kmclaughlin.
peterwaller-arm added a comment.

Tagging some more potential reviewers.



================
Comment at: llvm/test/Transforms/LoopVectorize/reduction.ll:539
+;    sum += src[i+1];
+;    dst[42] = sum;
+;  }
----------------
igor.kirillov wrote:
> peterwaller-arm wrote:
> > Suggestion for a test: what about testing two different destination addresses modified in the loop body?
> Actually this is not supported so far, only one invariant address is possible. (See llvm/lib/Analysis/IVDescriptors.cpp:318).  Do you think we need test that checks that vectorisation is not happening?
Given that it is not supported, such a test would demonstrate that your bailout logic for this case  is working as intended.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110235/new/

https://reviews.llvm.org/D110235