[PATCH] D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header

Esme Yi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 10 22:15:20 PDT 2021


Esme added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:906
+    if (Error E = AuxiliaryHeaderOrErr.takeError())
+      return std::move(E);
+    Obj->AuxiliaryHeader = AuxiliaryHeaderOrErr.get();
----------------
See D110320, it is better to report a detailed error message, i.g
`auxiliary header with offset ** and size ** goes past the end of the file`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82549/new/

https://reviews.llvm.org/D82549



More information about the llvm-commits mailing list