[PATCH] D111150: [AMDGPU] Remove dead frame indices after sgpr spill.

Christudasan Devadasan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 10 21:58:10 PDT 2021


cdevadas accepted this revision.
cdevadas added a comment.
This revision is now accepted and ready to land.

LGTM with a nitpick.



================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:446
   // The FP & BP spills haven't been inserted yet, so keep them around.
-  for (auto &R : SGPRToVGPRSpills) {
-    if (R.first != FramePointerSaveIndex && R.first != BasePointerSaveIndex)
+  //
+  // Apart from removing dead frame indices from function frame, also make sure
----------------
The extra comment line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111150/new/

https://reviews.llvm.org/D111150



More information about the llvm-commits mailing list