[PATCH] D111288: [fir] Add data flow optimization pass
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Oct 10 13:23:06 PDT 2021
jdoerfert added a comment.
In D111288#3053917 <https://reviews.llvm.org/D111288#3053917>, @mehdi_amini wrote:
> I think @jdoerfert request to document more careful the state of the code and the caveat seem reasonable to me.
> If you don't understand what is there enough to document it, then yeah maybe you shouldn't upstream it.
Here and for the other one. Put a warning in the commit message and file comment. In both cases list the things I said as potential problems. State it is a prototype and not necessarily production quality.
Then it's fine to be upstreamed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111288/new/
https://reviews.llvm.org/D111288
More information about the llvm-commits
mailing list