[PATCH] D111155: [fir] Add affine promotion pass

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D111155#3053414 <https://reviews.llvm.org/D111155#3053414>, @jdoerfert wrote:

> Again, glancing at these transformations makes me doubt how well they are tested. The documentation doesn't seem to indicate this is a WIP or not ready yet.
> I only read over parts and found 3 things that I suspect are "broken", for some definition of the word. (The multi symbol stuff is technically not a correctness issue.)
>
> I'm also guessing we ignore overflows and such completely when we do these things, right?

As for the patch related to affine promotion/demotion these are prototype. I would be happy to add a mention in the comment about that. Alternatively, we can also not upstream these transformations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111155/new/

https://reviews.llvm.org/D111155