[PATCH] D111288: [fir] Add data flow optimization pass

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D111288#3053413 <https://reviews.llvm.org/D111288#3053413>, @jdoerfert wrote:

> In D111288#3052150 <https://reviews.llvm.org/D111288#3052150>, @schweitz wrote:
>
>> Another alternative is to not bother upstreaming it, since it may be "too much of a prototype" (It's not always super clear how to distinguish "overly prototype-y" from "prototype-y but possibly useful in a new project.), and let someone figure out what to do in the future. Pros: It's not there and no one will mistakenly assume its robust, productized code by mistake. Cons: It's not there, so the reference point, lessons learned, etc. are likely to just be lost over time.
>
> I'm fine with it being there in a state like this but not without actual comments, in the code and commit message, telling people that this is not sound. Dropping some code that is known buggy without any form of documentation is not helpful for anyone.

As Eric mentioned we are not the authors of this code and we have two options here:

1. We upstream the code in its current shape (we can add a comment mentioning that) so the broader community can start from it.
2. We do not upstream these transformations and any new effort will have to start from scratch on that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111288/new/

https://reviews.llvm.org/D111288