[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions
Carlos Galvez via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Oct 10 03:10:59 PDT 2021
carlosgalvezp added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:446
SuppressionErrors.emplace_back(Error.getValue());
- return false;
}
----------------
I had to remove these "return false", otherwise I would not get errors regarding "Found NOLINTBEGIN that was unmatched by a NOLINTEND". Not really sure why they were there in the first place.
All unit tests pass with this patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111208/new/
https://reviews.llvm.org/D111208
More information about the llvm-commits
mailing list