[PATCH] D111436: [ELF][test] Add testing for dynamic TLS relocations in .debug_info
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Oct 9 09:44:51 PDT 2021
MaskRay added a comment.
In D111436#3053359 <https://reviews.llvm.org/D111436#3053359>, @andrewng wrote:
> In D111436#3051813 <https://reviews.llvm.org/D111436#3051813>, @MaskRay wrote:
>
>> Please place this in one of the `x86-64-tls-ld*.s` files. For ppc64 we use `ppc64-dtprel.s`
>
> This test is testing the patching behaviour of DTPREL in non-alloc sections, specifically `.debug_info` because that's the usual use case, so I'm not sure it really fits with the `x86-64-tls-ld*.s` tests. Do you want me to rename this test to `x86-64-dtprel.s` or do you have another suggestion?
DTPREL relocations are used in the local-dynamic TLS model. The non-alloc section context is slightly different, but I think just reusing one file is fine (in this case I think fewer tests are easier to organize).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111436/new/
https://reviews.llvm.org/D111436
More information about the llvm-commits
mailing list