[llvm] e2a2e54 - Revert "Reland "[gn build] (manually) port 6fe2beba7d2a (ExceptionTests)""

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 9 07:19:36 PDT 2021


Author: Nico Weber
Date: 2021-10-09T10:18:52-04:00
New Revision: e2a2e5475cbd370044474e132a1b5c58e6a3d458

URL: https://github.com/llvm/llvm-project/commit/e2a2e5475cbd370044474e132a1b5c58e6a3d458
DIFF: https://github.com/llvm/llvm-project/commit/e2a2e5475cbd370044474e132a1b5c58e6a3d458.diff

LOG: Revert "Reland "[gn build] (manually) port 6fe2beba7d2a (ExceptionTests)""

This reverts commit 842035d8bdf470af05848114ce1808802c5d4aef.
1dba6b3 was reverted yet again in 04aff395047a.

Added: 
    

Modified: 
    llvm/utils/gn/secondary/clang/unittests/BUILD.gn
    llvm/utils/gn/secondary/llvm/utils/unittest/BUILD.gn

Removed: 
    llvm/utils/gn/secondary/clang/unittests/Interpreter/ExceptionTests/BUILD.gn


################################################################################
diff  --git a/llvm/utils/gn/secondary/clang/unittests/BUILD.gn b/llvm/utils/gn/secondary/clang/unittests/BUILD.gn
index 3322ca4f2a195..319205b5831bb 100644
--- a/llvm/utils/gn/secondary/clang/unittests/BUILD.gn
+++ b/llvm/utils/gn/secondary/clang/unittests/BUILD.gn
@@ -29,16 +29,13 @@ group("unittests") {
     ]
   }
   if (host_os != "win") {
+    # FIXME: libclang unit tests are disabled on Windows due
+    # to failures, mostly in libclang.VirtualFileOverlay_*.
+    # FIXME: Also, the executable can't find libclang.dll since that's
+    # in a 
diff erent directory.
     deps += [
-      # FIXME: libclang unit tests are disabled on Windows due
-      # to failures, mostly in libclang.VirtualFileOverlay_*.
-      # FIXME: Also, the executable can't find libclang.dll since that's
-      # in a 
diff erent directory.
       "libclang:libclangTests",
       "libclang/CrashTests:libclangCrashTests",
-
-      # Exceptions on Windows are not yet supported.
-      "Interpreter/ExceptionTests:ClangReplInterpreterExceptionTests",
     ]
   }
   testonly = true

diff  --git a/llvm/utils/gn/secondary/clang/unittests/Interpreter/ExceptionTests/BUILD.gn b/llvm/utils/gn/secondary/clang/unittests/Interpreter/ExceptionTests/BUILD.gn
deleted file mode 100644
index 5b0173badd658..0000000000000
--- a/llvm/utils/gn/secondary/clang/unittests/Interpreter/ExceptionTests/BUILD.gn
+++ /dev/null
@@ -1,20 +0,0 @@
-import("//llvm/utils/unittest/unittest.gni")
-
-unittest("ClangReplInterpreterExceptionTests") {
-  configs += [ "//llvm/utils/gn/build:clang_code" ]
-  configs -= [
-    "//llvm/utils/gn/build:no_exceptions",
-    "//llvm/utils/gn/build:no_rtti",
-  ]
-  deps = [
-    "//clang/lib/AST",
-    "//clang/lib/Basic",
-    "//clang/lib/Interpreter",
-    "//clang/lib/Frontend",
-    "//llvm/lib/IR",
-    "//llvm/lib/ExecutionEngine/Orc",
-    "//llvm/lib/Support",
-    "//llvm/lib/Target:TargetsToBuild",
-  ]
-  sources = [ "InterpreterExceptionTest.cpp" ]
-}

diff  --git a/llvm/utils/gn/secondary/llvm/utils/unittest/BUILD.gn b/llvm/utils/gn/secondary/llvm/utils/unittest/BUILD.gn
index 844e43c856f4f..ccdb401a4b834 100644
--- a/llvm/utils/gn/secondary/llvm/utils/unittest/BUILD.gn
+++ b/llvm/utils/gn/secondary/llvm/utils/unittest/BUILD.gn
@@ -27,7 +27,6 @@ static_library("gtest") {
   ]
   public_configs = [ ":googletest_config" ]
   configs -= [ "//llvm/utils/gn/build:warn_covered_switch_default" ]
-  configs -= [ "//llvm/utils/gn/build:no_rtti" ]
   sources = [
     "googlemock/src/gmock-all.cc",
     "googletest/src/gtest-all.cc",


        


More information about the llvm-commits mailing list