[PATCH] D110904: [lld-macho] Downgrade missing -arch initially to error.

[Vincent Lee via Phabricator via llvm-commits]

thevinster added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1347
+    // good.
+    if (target->isPlaceHolder())
+      fatal("unknown target platform - giving up");
----------------
I'm not sure how I feel about having all this code about a dummy struct just so we can avoid the typo scenario you mentioned. To me, it feels like an indirection just to get to the actual root cause. What's the difference between this and moving `createTargetInfo` here instead? It seems like the same result can be achieved and it's easier to reason about. 

I'm curious to know what others think tho...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110904/new/

https://reviews.llvm.org/D110904