[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In D80833#2069411 <https://reviews.llvm.org/D80833#2069411>, @aganea wrote:

> In D80833#2069246 <https://reviews.llvm.org/D80833#2069246>, @amccarth wrote:
>
>> Does embedding full paths affect distributed builds or build reproducibility?
>
> It does affect reproducibility for distributed builds, the contents of `LF_BUILDINFO` for a remotely-compiled .OBJ will be different in the final .PDB.

I don't think the path to the compiler is the only concern regarding reproducible builds. Including the full command-line means that artifacts change when options that have no (other) effect on the output are added. E.g., adding `-Wall` will create a different object file than `-Wmost`. I worry this is the wrong direction for default clang behaviour.

Should this new instability be restricted to when users explicitly request it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80833/new/

https://reviews.llvm.org/D80833