[PATCH] D111410: [InstCombine] generalize fold for mask-with-signbit-splat

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 8 07:46:04 PDT 2021


spatel added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/sub-ashr-and-to-icmp-select.ll:134
 ; CHECK-NEXT:    store i32 [[SUB]], i32* [[P:%.*]], align 4
-; CHECK-NEXT:    [[TMP1:%.*]] = icmp slt i32 [[Y]], [[X]]
-; CHECK-NEXT:    [[AND:%.*]] = select i1 [[TMP1]], i32 [[X]], i32 0
+; CHECK-NEXT:    [[ISNEG:%.*]] = icmp slt i32 [[SUB]], 0
+; CHECK-NEXT:    [[AND:%.*]] = select i1 [[ISNEG]], i32 [[X]], i32 0
----------------
This is the missing icmp fold - it checks hasOneUse(), but that is not strictly necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111410/new/

https://reviews.llvm.org/D111410



More information about the llvm-commits mailing list