[PATCH] D111395: [flang][driver] Fix erroneous `&`

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 8 07:40:11 PDT 2021


awarzynski added a comment.

In D111395#3051073 <https://reviews.llvm.org/D111395#3051073>, @PeteSteinfeld wrote:

> In D111395#3051044 <https://reviews.llvm.org/D111395#3051044>, @awarzynski wrote:
>
>> In D111395#3050964 <https://reviews.llvm.org/D111395#3050964>, @PeteSteinfeld wrote:
>>
>>> Rather than continue with this patch, I would think that we'd just want to make an analogous change to https://reviews.llvm.org/D111308.
>>
>> This would mean making two unrelated changes in one patch. This patch updates `PrescanAndSemaAction`. This fix is not required in https://reviews.llvm.org/D111308, which implements a new frontend action base class, `PrescanAndSemaDebugAction`.
>
> Sounds good.  Go for it!

Thank you for reviewing! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111395/new/

https://reviews.llvm.org/D111395



More information about the llvm-commits mailing list